Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some clean up no clue if working #7944

Closed

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Aug 30, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (1f4cbbb) to head (4dd3778).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7944      +/-   ##
==========================================
+ Coverage   64.29%   64.33%   +0.04%     
==========================================
  Files        3674     3677       +3     
  Lines       81149    81202      +53     
  Branches    12928    12945      +17     
==========================================
+ Hits        52173    52240      +67     
+ Misses      25765    25750      -15     
- Partials     3211     3212       +1     
Flag Coverage Δ
Linux_1 ?
Linux_2 56.19% <ø> (ø)
Linux_3 40.61% <ø> (+<0.01%) ⬆️
Linux_4 31.40% <ø> (ø)
Windows_1 30.76% <ø> (+0.53%) ⬆️
Windows_2 56.14% <ø> (ø)
Windows_3 40.61% <ø> (ø)
Windows_4 31.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant