fix(discover): switch language based on dataset selection #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
github-actions
bot
added
seasoned-contributor
Skip-Changelog
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7924 +/- ##
==========================================
- Coverage 64.30% 64.30% -0.01%
==========================================
Files 3674 3674
Lines 81135 81135
Branches 12926 12927 +1
==========================================
- Hits 52173 52171 -2
- Misses 25751 25752 +1
- Partials 3211 3212 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
reviewed
Sep 3, 2024
| @@ -57,8 +57,8 @@ export class LanguageService { | |||
| this.languages.set(config.id, config); | |||
| } | |||
|
|
|||
| public getLanguage(language: string): LanguageConfig | undefined { | |||
| return this.languages.get(language); | |||
| public getLanguage(languageId: string): LanguageConfig | undefined { | |||
There was a problem hiding this comment.
Is this a released public API we are changing? If unreleased ignore plz.
There was a problem hiding this comment.
changing the parameter variable name shouldn't affect users of this API, and regarding documentation i don't think it's released, didn't find documentation for it
AMoo-Miki
approved these changes
Sep 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix(discover): switch language based on dataset selection Signed-off-by: Joshua Li <[email protected]> * keep currently selected language as default option Signed-off-by: Joshua Li <[email protected]> * update supportedLanguages mock Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit edabe3b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 3, 2024
) * fix(discover): switch language based on dataset selection * keep currently selected language as default option * update supportedLanguages mock --------- (cherry picked from commit edabe3b) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the advanced dataset selector allows user to change language, but it doesn't affect UI on submit. this PR fixes it
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration