[Workspace] Refactor get start card at new home page #7920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
…oards into 2.17/refactor-get-started-card
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Signed-off-by: yubonluo <[email protected]>
…OpenSearch-Dashboards into 2.17/refactor-get-started-card
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7920 +/- ##
==========================================
- Coverage 64.33% 64.33% -0.01%
==========================================
Files 3677 3678 +1
Lines 81206 81202 -4
Branches 12946 12943 -3
==========================================
- Hits 52243 52238 -5
Misses 25750 25750
- Partials 3213 3214 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
reviewed
Aug 30, 2024
src/plugins/workspace/public/components/home_get_start_card/setup_get_start_card.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Aug 30, 2024
src/plugins/workspace/public/components/home_get_start_card/setup_get_start_card.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Aug 30, 2024
src/plugins/content_management/public/components/card_container/card_embeddable.tsx
Show resolved
Hide resolved
ruanyl
previously approved these changes
Aug 30, 2024
src/plugins/workspace/public/components/home_get_start_card/use_case_card_title.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/home_get_start_card/use_case_card_title.tsx
Outdated
Show resolved
Hide resolved
…oards into 2.17/refactor-get-started-card
Signed-off-by: yubonluo <[email protected]>
ruanyl
approved these changes
Sep 2, 2024
SuZhou-Joe
approved these changes
Sep 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
* refactor started card Signed-off-by: yubonluo <[email protected]> * refactor new home page get start card Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7920 created/updated * revert code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d13007a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 3, 2024
* refactor started card * refactor new home page get start card * Changeset file for PR #7920 created/updated * revert code * optimize the code --------- (cherry picked from commit d13007a) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor get start card at new home page according the latest ui design.
The card icon will been update as the followed commit.
Issues Resolved
Screenshot
2024-08-29.23.15.27.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration