Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] refine style of workspace list table #7913

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Aug 29, 2024

Description

In this pr, I make a small change for the work list table followed by Trineo: Fit and Finish Guidance :

  1. compress input
  2. change back text size to xs, according to "Please DO NOT increase the size of existing extra-small text that is associated with tables, form elements, or where we may have intentionally chosen an extra-small size"

Screenshot

Screenshot 2024-08-29 at 15 13 29

Changelog

  • fix: refactor the style for the work list table

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (04fca30) to head (53bd3df).
Report is 148 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7913      +/-   ##
==========================================
+ Coverage   63.83%   64.30%   +0.46%     
==========================================
  Files        3661     3674      +13     
  Lines       81362    81135     -227     
  Branches    12982    12926      -56     
==========================================
+ Hits        51941    52173     +232     
+ Misses      26235    25751     -484     
- Partials     3186     3211      +25     
Flag Coverage Δ
Linux_1 30.21% <ø> (+0.05%) ⬆️
Linux_2 56.19% <ø> (+0.31%) ⬆️
Linux_3 40.62% <ø> (+0.22%) ⬆️
Linux_4 31.40% <ø> (+0.06%) ⬆️
Windows_1 30.23% <ø> (+0.05%) ⬆️
Windows_2 56.14% <ø> (+0.31%) ⬆️
Windows_3 40.62% <ø> (+0.22%) ⬆️
Windows_4 31.40% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 73765cd into opensearch-project:main Aug 30, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
* fix, meet norms

Signed-off-by: Qxisylolo <[email protected]>

* 01-apply-new-standards

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR #7913 created/updated

* Changeset file for PR #7913 created/updated

* Changeset file for PR #7913 created/updated

* Changeset file for PR #7913 created/updated

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 73765cd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 30, 2024
* fix, meet norms



* 01-apply-new-standards



* Changeset file for PR #7913 created/updated

* Changeset file for PR #7913 created/updated

* Changeset file for PR #7913 created/updated

* Changeset file for PR #7913 created/updated

---------



(cherry picked from commit 73765cd)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants