-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discover] update query assist icon #7898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
August 28, 2024 22:33
github-actions
bot
added
seasoned-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
labels
Aug 28, 2024
zhongnansu
approved these changes
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7898 +/- ##
==========================================
- Coverage 64.27% 64.26% -0.01%
==========================================
Files 3673 3673
Lines 81187 81187
Branches 12943 12943
==========================================
- Hits 52179 52177 -2
- Misses 25795 25796 +1
- Partials 3213 3214 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
approved these changes
Aug 28, 2024
abbyhu2000
approved these changes
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a8e427) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Aug 28, 2024
(cherry picked from commit 7a8e427) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
discover
for discover reinvent
seasoned-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
v2.17.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update query assist icon
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration