Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support injecting DataStructureMeta from QueryEditorExtensions for Query Assist #7888

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9bc2433 from #7871.

…r Query Assist (#7871)

* fix query editor extensions enhance key

Signed-off-by: Joshua Li <[email protected]>

* add query assist icons to clusters if available

Signed-off-by: Joshua Li <[email protected]>

* allow custom icon for `DATA_STRUCTURE_META_TYPES.FEATURE`

Signed-off-by: Joshua Li <[email protected]>

* Changeset file for PR #7871 created/updated

---------

Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 9bc2433)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 13.15789% with 33 lines in your changes missing coverage. Please review.

Project coverage is 64.27%. Comparing base (8c779c1) to head (454c7e1).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ic/query/query_string/dataset_service/lib/utils.ts 6.25% 15 Missing ⚠️
...nts/public/query_assist/utils/create_extension.tsx 22.22% 14 Missing ⚠️
...y_string/dataset_service/lib/index_pattern_type.ts 0.00% 2 Missing ⚠️
...ery/query_string/dataset_service/lib/index_type.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7888      +/-   ##
==========================================
- Coverage   64.28%   64.27%   -0.02%     
==========================================
  Files        3658     3659       +1     
  Lines       80790    80813      +23     
  Branches    12865    12867       +2     
==========================================
+ Hits        51936    51941       +5     
- Misses      25672    25690      +18     
  Partials     3182     3182              
Flag Coverage Δ
Linux_1 30.32% <5.00%> (-0.01%) ⬇️
Linux_2 56.04% <ø> (ø)
Linux_3 40.70% <5.00%> (-0.02%) ⬇️
Linux_4 31.54% <13.15%> (-0.01%) ⬇️
Windows_1 30.34% <5.00%> (-0.01%) ⬇️
Windows_2 55.99% <ø> (ø)
Windows_3 40.70% <5.00%> (-0.02%) ⬇️
Windows_4 31.54% <13.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc merged commit a9e7068 into 2.x Aug 28, 2024
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants