Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Page Header]Render filter bar in full width with application header #7886

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[Page Header]Render filter bar in full width with application header #7886

merged 1 commit into from
Aug 29, 2024

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Aug 28, 2024 •
edited
Loading

Description

  • create a portal for filter bar component to render on its own row
  • Add a reference point that next to header
  • Note that for discover, we still need filter bar to render as part of the SearchBar component

Issues Resolved

Screenshot

  • with filters

image
image

  • without filters
    image
    image

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added failed changeset Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Aug 28, 2024
@zhongnansu zhongnansu marked this pull request as ready for review August 28, 2024 11:35
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (5e0ce2b) to head (08ea17c).
Report is 137 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7886      +/-   ##
==========================================
+ Coverage   64.22%   64.30%   +0.07%     
==========================================
  Files        3672     3673       +1     
  Lines       81154    81126      -28     
  Branches    12939    12928      -11     
==========================================
+ Hits        52125    52169      +44     
+ Misses      25821    25745      -76     
- Partials     3208     3212       +4
Flag Coverage Δ
Linux_1 30.21% <ø> (+0.01%) ⬆️
Linux_2 56.19% <ø> (+0.11%) ⬆️
Linux_3 40.60% <ø> (+0.03%) ⬆️
Linux_4 31.41% <ø> (+0.08%) ⬆️
Windows_1 30.23% <ø> (+0.01%) ⬆️
Windows_2 56.14% <ø> (+0.11%) ⬆️
Windows_3 40.61% <ø> (+0.05%) ⬆️
Windows_4 31.41% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu added backport 2.x v2.17.0 look & feel Look and Feel Improvements labels Aug 28, 2024
@virajsanghvi
Copy link
Collaborator

Can you post a screenshot of what it looks like with no filters?

@zhongnansu
Copy link
Member Author

Can you post a screenshot of what it looks like with no filters?

added to the PR description

virajsanghvi
virajsanghvi previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, although please validate failing tests are unrelated

@zhongnansu zhongnansu merged commit 6e0a632 into opensearch-project:main Aug 29, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2024
@github-actions
[Page Header]Render filter bar in full width with application header (#…
78259f0 
…7886)

(cherry picked from commit 6e0a632)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 29, 2024
Merged
zhongnansu pushed a commit that referenced this pull request Sep 3, 2024
@github-actions @zhongnansu
[Page Header]Render filter bar in full width with application header (#…
f67b5b5 
…7886)

(cherry picked from commit 6e0a632)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu pushed a commit that referenced this pull request Sep 3, 2024
@opensearch-trigger-bot @github-actions
[Page Header]Render filter bar in full width with application header (#…
df790e0 
…7886) (#7903)

(cherry picked from commit 6e0a632)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor in-next look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhongnansu @virajsanghvi @ZilongX @AMoo-Miki