Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover 2.0] UI Fixes #7885

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Aug 28, 2024

Description

Fixes Discover UI issues with the data selector and query bar

  1. Dataseletor wdth now stays constant unless smaller than window
  2. Querybar matches the mocks better

Issues Resolved

Screenshot

Screen.Recording.2024-08-28.at.4.04.53.AM.mov

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.21%. Comparing base (5e0ce2b) to head (022083c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...c/ui/query_editor/editors/default_editor/index.tsx 0.00% 3 Missing ⚠️
...ins/data/public/ui/query_editor/editors/shared.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7885      +/-   ##
==========================================
- Coverage   64.22%   64.21%   -0.02%     
==========================================
  Files        3672     3673       +1     
  Lines       81154    81177      +23     
  Branches    12939    12941       +2     
==========================================
+ Hits        52125    52127       +2     
- Misses      25821    25841      +20     
- Partials     3208     3209       +1     
Flag Coverage Δ
Linux_1 30.20% <0.00%> (-0.01%) ⬇️
Linux_2 56.08% <ø> (ø)
Linux_3 40.55% <0.00%> (-0.02%) ⬇️
Linux_4 31.31% <0.00%> (-0.01%) ⬇️
Windows_1 30.21% <0.00%> (-0.01%) ⬇️
Windows_2 56.03% <ø> (ø)
Windows_3 40.55% <0.00%> (-0.02%) ⬇️
Windows_4 31.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ashwin P Chandran <[email protected]>
sejli
sejli previously approved these changes Aug 28, 2024
abbyhu2000
abbyhu2000 previously approved these changes Aug 28, 2024
{footerItems.end?.map((item) => (
<EuiFlexItem grow={false}>{item}</EuiFlexItem>
<EuiFlexItem grow={false} className="defaultEditor__footerItem">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this className defaultEditor__footerItem? i see it got deleted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but keeping it in case we do

Signed-off-by: Ashwin P Chandran <[email protected]>
@ashwin-pc ashwin-pc dismissed stale reviews from abbyhu2000 and sejli via 6768169 August 28, 2024 18:02
Signed-off-by: Ashwin P Chandran <[email protected]>
@ashwin-pc ashwin-pc merged commit eefbdfd into opensearch-project:main Aug 28, 2024
66 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7885-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eefbdfd26f45a247cd85f3c4bc39d4ca1ea1a190
# Push it to GitHub
git push --set-upstream origin backport/backport-7885-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7885-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
* [Discover 2.0] UI Fixes

Signed-off-by: Ashwin P Chandran <[email protected]>

* minor fixes

Signed-off-by: Ashwin P Chandran <[email protected]>

* fix test failures

Signed-off-by: Ashwin P Chandran <[email protected]>

* fix test

Signed-off-by: Ashwin P Chandran <[email protected]>

* fix bootstrap

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit eefbdfd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Aug 28, 2024
* [Discover 2.0] UI Fixes



* minor fixes



* fix test failures



* fix test



* fix bootstrap



---------


(cherry picked from commit eefbdfd)

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants