-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover 2.0] UI Fixes #7885
[Discover 2.0] UI Fixes #7885
Conversation
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7885 +/- ##
==========================================
- Coverage 64.22% 64.21% -0.02%
==========================================
Files 3672 3673 +1
Lines 81154 81177 +23
Branches 12939 12941 +2
==========================================
+ Hits 52125 52127 +2
- Misses 25821 25841 +20
- Partials 3208 3209 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashwin P Chandran <[email protected]>
{footerItems.end?.map((item) => ( | ||
<EuiFlexItem grow={false}>{item}</EuiFlexItem> | ||
<EuiFlexItem grow={false} className="defaultEditor__footerItem"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this className defaultEditor__footerItem
? i see it got deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but keeping it in case we do
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7885-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eefbdfd26f45a247cd85f3c4bc39d4ca1ea1a190
# Push it to GitHub
git push --set-upstream origin backport/backport-7885-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* [Discover 2.0] UI Fixes Signed-off-by: Ashwin P Chandran <[email protected]> * minor fixes Signed-off-by: Ashwin P Chandran <[email protected]> * fix test failures Signed-off-by: Ashwin P Chandran <[email protected]> * fix test Signed-off-by: Ashwin P Chandran <[email protected]> * fix bootstrap Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> (cherry picked from commit eefbdfd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [Discover 2.0] UI Fixes * minor fixes * fix test failures * fix test * fix bootstrap --------- (cherry picked from commit eefbdfd) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fixes Discover UI issues with the data selector and query bar
Issues Resolved
Screenshot
Screen.Recording.2024-08-28.at.4.04.53.AM.mov
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration