Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation] display workspace picker content when outside workspace and nav group #7882

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 28, 2024

Backport 56fc8f4 from #7716.

…and nav group (#7716) (#7880)

* feat: show workspace picker content in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: only register index patterns to settings and setup when workspace is disabled

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: put discover 2.0 behind discover

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: improve test coverage

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge conflict

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize filter code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 56fc8f4)
(cherry picked from commit b02dd2b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 89.04110% with 16 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (f64a270) to head (36b5097).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...chrome/ui/header/collapsible_nav_group_enabled.tsx 84.90% 0 Missing and 8 partials ⚠️
...public/chrome/ui/header/collapsible_nav_groups.tsx 87.09% 1 Missing and 3 partials ⚠️
src/core/public/chrome/ui/header/header.tsx 0.00% 0 Missing and 2 partials ⚠️
.../plugins/index_pattern_management/public/plugin.ts 66.66% 0 Missing and 1 partial ⚠️
...kspace_picker_content/workspace_picker_content.tsx 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7882   +/-   ##
=======================================
  Coverage   64.27%   64.28%           
=======================================
  Files        3656     3658    +2     
  Lines       80742    80788   +46     
  Branches    12848    12864   +16     
=======================================
+ Hits        51897    51934   +37     
- Misses      25671    25672    +1     
- Partials     3174     3182    +8     
Flag Coverage Δ
Linux_1 30.33% <27.27%> (+<0.01%) ⬆️
Linux_2 56.04% <86.91%> (+0.02%) ⬆️
Linux_3 40.71% <3.63%> (-0.01%) ⬇️
Linux_4 31.55% <5.45%> (-0.02%) ⬇️
Windows_1 30.35% <27.27%> (+<0.01%) ⬆️
Windows_2 55.99% <86.91%> (+0.02%) ⬆️
Windows_3 40.71% <3.63%> (-0.03%) ⬇️
Windows_4 31.55% <5.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 5b809af into 2.x Aug 28, 2024
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants