[Workspace] Update collaborator input to text field #7879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7879 +/- ##
==========================================
+ Coverage 64.22% 64.30% +0.07%
==========================================
Files 3672 3674 +2
Lines 81152 81135 -17
Branches 12938 12927 -11
==========================================
+ Hits 52121 52172 +51
+ Misses 25822 25752 -70
- Partials 3209 3211 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
wanglam
reviewed
Aug 29, 2024
| onChange={handleGroupOrUserIdChange} | ||
| value={type === WorkspacePermissionItemType.User ? userId ?? '' : group ?? ''} |
There was a problem hiding this comment.
Prefer rewrite with (type === WorkspacePermissionItemType.User ? userId : group) ?? ''
| onChange={handleGroupOrUserIdChange} | ||
| value={type === WorkspacePermissionItemType.User ? userId ?? '' : group ?? ''} | ||
| data-test-subj="fieldtextInput" |
There was a problem hiding this comment.
Prefer using a meaningful test id, such as workspaceFormUserIdOrGroupInput
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
ruanyl
approved these changes
Aug 30, 2024
SuZhou-Joe
approved these changes
Aug 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Change the collaborator input from a combobox to a text field Signed-off-by: Kapian1234 <[email protected]> * resolve some problems Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7879 created/updated * resolve some issues Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4c1e3e6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 2, 2024
* Change the collaborator input from a combobox to a text field * resolve some problems * Changeset file for PR #7879 created/updated * resolve some issues --------- (cherry picked from commit 4c1e3e6) Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the collaborator input from a combobox to a text field
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration