-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] search use case overview page #7877
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
51ca3b1
to
3c5a7bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7877 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 3685 3687 +2
Lines 87143 87191 +48
Branches 13405 13411 +6
=======================================
+ Hits 53169 53200 +31
- Misses 30755 30770 +15
- Partials 3219 3221 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
633a089
to
618a85f
Compare
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
@@ -168,6 +174,36 @@ export class HomePublicPlugin | |||
workspaceAvailability: WorkspaceAvailability.outsideWorkspace, | |||
}); | |||
|
|||
if (core.chrome.navGroup.getNavGroupEnabled()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Not sure if it is suitable to register the page inside home plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, It's a little wired we put into home plugin, we might need to have a new plugin to store use case overview pages.
src/plugins/home/public/application/components/usecase_overview/search_use_case_setup.tsx
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7877-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9697f33da4bfab7e0dc1f10b308c152739a982ce
# Push it to GitHub
git push --set-upstream origin backport/backport-7877-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
backport depends on #7937 to merged first |
* search overview Signed-off-by: Hailong Cui <[email protected]> * add unit test for search use case overview page Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #7877 created/updated * fix merge issue Signed-off-by: Hailong Cui <[email protected]> * udpate breadcrumbs for workspace overview page Signed-off-by: Hailong Cui <[email protected]> * fix failed ut Signed-off-by: Hailong Cui <[email protected]> * fix merge issue Signed-off-by: Hailong Cui <[email protected]> * fix ut Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 9697f33) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* search overview * add unit test for search use case overview page * Changeset file for PR #7877 created/updated * fix merge issue * udpate breadcrumbs for workspace overview page * fix failed ut * fix merge issue * fix ut --------- (cherry picked from commit 9697f33) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-7877-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9697f33da4bfab7e0dc1f10b308c152739a982ce
# Push it to GitHub
git push --set-upstream origin backport/backport-7877-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
* search overview * add unit test for search use case overview page * Changeset file for PR #7877 created/updated * fix merge issue * udpate breadcrumbs for workspace overview page * fix failed ut * fix merge issue * fix ut --------- (cherry picked from commit 9697f33) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 3d7b9ed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* search overview * add unit test for search use case overview page * Changeset file for PR #7877 created/updated * fix merge issue * udpate breadcrumbs for workspace overview page * fix failed ut * fix merge issue * fix ut --------- (cherry picked from commit 9697f33) (cherry picked from commit 3d7b9ed) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Description
Add search use case overview page
breadcrumbs will handled by other PR
Issues Resolved
#7807
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration