-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auto Suggest] PPL and minor interface changes #7849
Conversation
…d move suggestion provider registration location (#7758) * add table/source as prefix to suggested fields Signed-off-by: Eric <[email protected]> * add type to column Signed-off-by: Eric <[email protected]> * move registeration to osd/monaco Signed-off-by: Eric <[email protected]> * add detail Signed-off-by: Eric <[email protected]> * Changeset file for PR #7758 created/updated --------- Signed-off-by: Eric <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 7849.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7849 +/- ##
==========================================
+ Coverage 63.82% 63.83% +0.01%
==========================================
Files 3650 3661 +11
Lines 80966 81345 +379
Branches 12894 12978 +84
==========================================
+ Hits 51673 51926 +253
- Misses 26126 26234 +108
- Partials 3167 3185 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* add initial ppl autocomplete Signed-off-by: Eric <[email protected]> * untrack .antlr files Signed-off-by: Eric <[email protected]> * ignore intermediate grammar auto-gen files Signed-off-by: Eric <[email protected]> * add rules and related functionalities Signed-off-by: Eric <[email protected]> * Changeset file for PR #7810 created/updated * Changeset file for PR #7810 created/updated * minor comment cleanning Signed-off-by: Eric <[email protected]> * add ppl generation command Signed-off-by: Eric <[email protected]> * add rules Signed-off-by: Eric <[email protected]> * correct typo Signed-off-by: Eric <[email protected]> * fix inserting text issue Signed-off-by: Eric <[email protected]> * remove colon for PPL field Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 7849.yml under folder changelogs/fragments to complete this PR. File still missing. |
…d move suggestion provider registration location (#7758)
add table/source as prefix to suggested fields
add type to column
move registeration to osd/monaco
add detail
Changeset file for PR [Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location #7758 created/updated
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration