Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Suggest] PPL and minor interface changes #7849

Closed
wants to merge 2 commits into from

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Aug 26, 2024

…d move suggestion provider registration location (#7758)


Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…d move suggestion provider registration location (#7758)

* add table/source as prefix to suggested fields

Signed-off-by: Eric <[email protected]>

* add type to column

Signed-off-by: Eric <[email protected]>

* move registeration to osd/monaco

Signed-off-by: Eric <[email protected]>

* add detail

Signed-off-by: Eric <[email protected]>

* Changeset file for PR #7758 created/updated

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7849.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (ae7cfa6) to head (23798a0).
Report is 40 commits behind head on main.

Files Patch % Lines
...ata/public/antlr/opensearch_sql/code_completion.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7849      +/-   ##
==========================================
+ Coverage   63.82%   63.83%   +0.01%     
==========================================
  Files        3650     3661      +11     
  Lines       80966    81345     +379     
  Branches    12894    12978      +84     
==========================================
+ Hits        51673    51926     +253     
- Misses      26126    26234     +108     
- Partials     3167     3185      +18     
Flag Coverage Δ
Linux_1 30.15% <33.33%> (+0.11%) ⬆️
Linux_2 55.87% <ø> (+0.01%) ⬆️
Linux_3 40.39% <33.33%> (-0.02%) ⬇️
Linux_4 31.35% <33.33%> (+0.06%) ⬆️
Windows_1 30.16% <33.33%> (+0.11%) ⬆️
Windows_2 55.82% <ø> (+0.01%) ⬆️
Windows_3 40.39% <33.33%> (-0.02%) ⬇️
Windows_4 31.35% <33.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* add initial ppl autocomplete

Signed-off-by: Eric <[email protected]>

* untrack .antlr files

Signed-off-by: Eric <[email protected]>

* ignore intermediate grammar auto-gen files

Signed-off-by: Eric <[email protected]>

* add rules and related functionalities

Signed-off-by: Eric <[email protected]>

* Changeset file for PR #7810 created/updated

* Changeset file for PR #7810 created/updated

* minor comment cleanning

Signed-off-by: Eric <[email protected]>

* add ppl generation command

Signed-off-by: Eric <[email protected]>

* add rules

Signed-off-by: Eric <[email protected]>

* correct typo

Signed-off-by: Eric <[email protected]>

* fix inserting text issue

Signed-off-by: Eric <[email protected]>

* remove colon for PPL field

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@paulstn paulstn changed the title [Auto Suggest] Minor interface changes [Auto Suggest] PPL and minor interface changes Aug 27, 2024
Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 7849.yml under folder changelogs/fragments to complete this PR. File still missing.

@paulstn paulstn closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants