Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]fix: unit test failure introduced by #7749 #7834

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

SuZhou-Joe
Copy link
Member

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <[email protected]>
@github-actions github-actions bot added distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Aug 24, 2024
@SuZhou-Joe SuZhou-Joe changed the title [navigation]fix: unit test [navigation]fix: unit test failure introduced by #7749 Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (e62d303) to head (998ed37).
Report is 404 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7834      +/-   ##
==========================================
+ Coverage   63.83%   63.84%   +0.01%     
==========================================
  Files        3661     3661              
  Lines       81345    81345              
  Branches    12979    12979              
==========================================
+ Hits        51924    51936      +12     
+ Misses      26235    26223      -12     
  Partials     3186     3186              
Flag Coverage Δ
Linux_1 30.14% <ø> (?)
Linux_2 55.87% <ø> (ø)
Linux_3 40.39% <ø> (ø)
Linux_4 31.34% <ø> (ø)
Windows_1 30.18% <ø> (+0.02%) ⬆️
Windows_2 55.82% <ø> (ø)
Windows_3 40.39% <ø> (ø)
Windows_4 31.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 42ded5c into opensearch-project:main Aug 24, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor navigation Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry test:unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants