Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add flush to TopNavControlLinkData #7809

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a5882ee from #7801.

* Add `flush` to `TopNavControlLinkData`

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #7801 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a5882ee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.89%. Comparing base (7fba6ac) to head (5a05bdf).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7809   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files        3657     3657           
  Lines       81228    81228           
  Branches    12941    12941           
=======================================
+ Hits        51900    51902    +2     
+ Misses      26153    26152    -1     
+ Partials     3175     3174    -1     
Flag Coverage Δ
Linux_1 30.11% <ø> (ø)
Linux_2 55.99% <ø> (ø)
Linux_3 40.49% <ø> (+<0.01%) ⬆️
Linux_4 31.45% <ø> (ø)
Windows_1 30.12% <ø> (ø)
Windows_2 55.94% <ø> (ø)
Windows_3 40.47% <ø> (-0.01%) ⬇️
Windows_4 31.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming checks pass

@AMoo-Miki AMoo-Miki merged commit 702136b into 2.x Aug 22, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor failed changeset v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants