Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Adjust the appearance of collaborator panel #7795

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Kapian1234
Copy link
Contributor

@Kapian1234 Kapian1234 commented Aug 22, 2024

Description

"Adjust the appearance of the workspace collaborator section according to the new design."

Issues Resolved

Screenshot

Screenshot 2024-08-15 at 14 34 18 Screenshot 2024-08-22 at 11 29 20

Testing the changes

Changelog

  • feat: Adjust the appearance of collaborator panel

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (9d692ef) to head (bc6ee0f).
Report is 173 commits behind head on main.

Files with missing lines Patch % Lines
...kspace_form/workspace_permission_setting_input.tsx 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7795      +/-   ##
==========================================
- Coverage   63.81%   63.79%   -0.03%     
==========================================
  Files        3656     3656              
  Lines       81205    81188      -17     
  Branches    12949    12943       -6     
==========================================
- Hits        51823    51795      -28     
- Misses      26202    26214      +12     
+ Partials     3180     3179       -1     
Flag Coverage Δ
Linux_1 30.06% <88.88%> (-0.02%) ⬇️
Linux_2 55.87% <ø> (ø)
Linux_3 40.42% <ø> (-0.01%) ⬇️
Linux_4 31.28% <ø> (ø)
Windows_1 30.08% <88.88%> (-0.04%) ⬇️
Windows_2 55.82% <ø> (ø)
Windows_3 40.42% <ø> (ø)
Windows_4 31.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wanglam wanglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruanyl ruanyl merged commit 5b85b02 into opensearch-project:main Aug 23, 2024
74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2024
* Adjust the appearance of the workspace collaborator panel

Signed-off-by: Kapian1234 <[email protected]>

* Adjust the appearance of the workspace collaborator panel

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #7795 created/updated

---------

Signed-off-by: Kapian1234 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5b85b02)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 26, 2024
* Adjust the appearance of the workspace collaborator panel



* Adjust the appearance of the workspace collaborator panel



* Changeset file for PR #7795 created/updated

---------



(cherry picked from commit 5b85b02)

Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants