Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Workspace] Updated permission settings appearance #7784

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Backport 2.x] [Workspace] Updated permission settings appearance #7784

merged 1 commit into from
Aug 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport aed03fa from #7652.

@github-actions @opensearch-changeset-bot
[Workspace] Updated permission settings appearance (#7652)
24b1044 
* Changed permission control style

Signed-off-by: Kapian1234 <[email protected]>

* Merged the group section and user section, and added type switching.

Signed-off-by: Kapian1234 <[email protected]>

* Added isDisabled for permission control

Signed-off-by: Kapian1234 <[email protected]>

* Modified styles and added descriptions for permission control

Signed-off-by: Kapian1234 <[email protected]>

* /

Signed-off-by: Kapian1234 <[email protected]>

* Modified tests

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #7652 created/updated

* Modified tests

Signed-off-by: Kapian1234 <[email protected]>

* Modified tests

Signed-off-by: Kapian1234 <[email protected]>

* /

Signed-off-by: Kapian1234 <[email protected]>

* Modified tests

Signed-off-by: Kapian1234 <[email protected]>

* Remove the doc updates

Signed-off-by: Kapian1234 <[email protected]>

* Remove the doc updates

Signed-off-by: Kapian1234 <[email protected]>

* Resolve some issues

Signed-off-by: Kapian1234 <[email protected]>

* resolve some issues

Signed-off-by: Kapian1234 <[email protected]>

* Change type switch to popover style

Signed-off-by: Kapian1234 <[email protected]>

* Change type switch to popover style

Signed-off-by: Kapian1234 <[email protected]>

* Change type switch to popover style

Signed-off-by: Kapian1234 <[email protected]>

* Change type switch to popover style

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests

Signed-off-by: Kapian1234 <[email protected]>

* Resolve some issues

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests to increase coverage

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests

Signed-off-by: Kapian1234 <[email protected]>

* Modify tests

Signed-off-by: Kapian1234 <[email protected]>

---------

Signed-off-by: Kapian1234 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit aed03fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports repeat-contributor workspace v2.17.0 labels Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.87%. Comparing base (a7b08e8) to head (24b1044).
Report is 6 commits behind head on 2.x.

Files Patch % Lines
...kspace_form/workspace_permission_setting_input.tsx 84.00% 1 Missing and 3 partials ⚠️
...kspace_form/workspace_permission_setting_panel.tsx 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #7784   +/-   ##
=======================================
  Coverage   63.86%   63.87%           
=======================================
  Files        3657     3657           
  Lines       81107    81122   +15     
  Branches    12911    12916    +5     
=======================================
+ Hits        51801    51818   +17     
+ Misses      26182    26133   -49     
- Partials     3124     3171   +47
Flag Coverage Δ
Linux_1 30.14% <89.13%> (+0.02%) ⬆️
Linux_2 55.95% <ø> (ø)
Linux_3 40.53% <ø> (ø)
Linux_4 31.46% <ø> (ø)
Windows_1 30.15% <89.13%> (+0.02%) ⬆️
Windows_2 55.91% <ø> (ø)
Windows_3 40.53% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 179b37a into 2.x Aug 22, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDrago27 LDrago27 LDrago27 approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset repeat-contributor v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @LDrago27 @AMoo-Miki