Adapt the newsfeed button to the updated header #7774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
opensearch-changeset-bot bot
added a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Aug 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7774 +/- ##
==========================================
- Coverage 63.83% 63.80% -0.04%
==========================================
Files 3655 3656 +1
Lines 81126 81205 +79
Branches 12923 12950 +27
==========================================
+ Hits 51783 51809 +26
- Misses 26165 26215 +50
- Partials 3178 3181 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
reviewed
Aug 20, 2024
src/plugins/newsfeed/public/components/newsfeed_header_nav_button.tsx
Outdated
Show resolved
Hide resolved
Also: * renamed a private variable with theme's menu button for consistency Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
newsfeed-menu
branch
from
ee8bb3e to
f00797c
Compare
zhongnansu
approved these changes
Aug 21, 2024
ashwin-pc
approved these changes
Aug 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Also: * renamed a private variable with theme's menu button for consistency Signed-off-by: Miki <[email protected]> (cherry picked from commit ba5fe50) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 22, 2024
Also: * renamed a private variable with theme's menu button for consistency (cherry picked from commit ba5fe50) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt the newsfeed button to the updated header. This "plugin" is virtually disabled by removing the manifest file.
Also:
Changelog
Check List
yarn test:jestyarn test:jest_integration