Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] Refactor: update page header for settings, objects and index pattern page #7769

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Aug 20, 2024

Backport PR

#7744

Description

update page header for settings, objects and index pattern page

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@raintygao raintygao marked this pull request as ready for review August 20, 2024 08:09
@raintygao raintygao changed the title [Manual backport 2.x] Refactor: update page header for settings, objects and index pattern … [Manual backport 2.x] Refactor: update page header for settings, objects and index pattern page Aug 20, 2024
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (95c9f3a) to head (f4bb774).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...dex_pattern_wizard/create_index_pattern_wizard.tsx 66.66% 2 Missing and 2 partials ⚠️
...gement/public/management_section/mount_section.tsx 0.00% 2 Missing ⚠️
...c/plugins/index_pattern_management/public/mocks.ts 0.00% 1 Missing ⚠️
...gement_section/objects_table/components/header.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7769   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files        3652     3653    +1     
  Lines       80970    80990   +20     
  Branches    12875    12884    +9     
=======================================
+ Hits        51724    51740   +16     
- Misses      26085    26087    +2     
- Partials     3161     3163    +2     
Flag Coverage Δ
Linux_1 30.12% <0.00%> (-0.01%) ⬇️
Linux_2 55.97% <ø> (ø)
Linux_3 40.55% <35.29%> (+<0.01%) ⬆️
Linux_4 31.49% <68.00%> (+<0.01%) ⬆️
Windows_1 30.14% <0.00%> (-0.01%) ⬇️
Windows_2 55.93% <ø> (ø)
Windows_3 40.55% <35.29%> (+<0.01%) ⬆️
Windows_4 31.49% <68.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Aug 20, 2024
@SuZhou-Joe SuZhou-Joe merged commit 020c6e9 into opensearch-project:2.x Aug 20, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants