Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add an unified storage class for data plugin #7755

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9a84202 from #7701.

* add an unified storage class

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 9a84202)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 38.33333% with 37 lines in your changes missing coverage. Please review.

Project coverage is 63.87%. Comparing base (4a7375b) to head (ddbfbb0).
Report is 6 commits behind head on 2.x.

Files Patch % Lines
...ns/data/public/query/query_string/query_history.ts 25.00% 11 Missing and 1 partial ⚠️
src/plugins/data/public/ui/settings/settings.ts 0.00% 8 Missing ⚠️
src/plugins/data/common/storage/storage.ts 70.58% 2 Missing and 3 partials ⚠️
.../public/query/query_string/query_string_manager.ts 37.50% 5 Missing ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx 40.00% 3 Missing ⚠️
src/plugins/data/public/plugin.ts 0.00% 1 Missing ⚠️
...s/data/public/query/persisted_log/persisted_log.ts 0.00% 1 Missing ⚠️
...public/ui/query_string_input/query_bar_top_row.tsx 0.00% 1 Missing ⚠️
...ublic/ui/query_string_input/query_string_input.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7755      +/-   ##
==========================================
- Coverage   63.88%   63.87%   -0.02%     
==========================================
  Files        3652     3654       +2     
  Lines       80966    81010      +44     
  Branches    12873    12880       +7     
==========================================
+ Hits        51725    51743      +18     
- Misses      26083    26104      +21     
- Partials     3158     3163       +5     
Flag Coverage Δ
Linux_1 30.11% <0.00%> (-0.02%) ⬇️
Linux_2 55.94% <0.00%> (-0.04%) ⬇️
Linux_3 40.53% <38.33%> (-0.02%) ⬇️
Linux_4 31.46% <0.00%> (-0.03%) ⬇️
Windows_1 30.13% <0.00%> (-0.02%) ⬇️
Windows_2 55.89% <0.00%> (-0.04%) ⬇️
Windows_3 40.53% <38.33%> (-0.02%) ⬇️
Windows_4 31.46% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 20, 2024
@abbyhu2000 abbyhu2000 merged commit c25a965 into 2.x Aug 20, 2024
68 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover-next distinguished-contributor failed changeset Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants