-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Add right sidebar to workspace create form #7750
[Workspace]Add right sidebar to workspace create form #7750
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7750 +/- ##
==========================================
+ Coverage 64.30% 64.32% +0.02%
==========================================
Files 3674 3676 +2
Lines 81138 81185 +47
Branches 12927 12943 +16
==========================================
+ Hits 52174 52222 +48
+ Misses 25752 25751 -1
Partials 3212 3212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5eca186
to
1278a74
Compare
return { | ||
[RightSidebarScrollField.UseCase]: i18n.translate( | ||
'workspace.form.summary.panel.useCase.title', | ||
{ | ||
defaultMessage: 'Use case', | ||
} | ||
), | ||
[RightSidebarScrollField.Name]: i18n.translate('workspace.form.summary.panel.name.title', { | ||
defaultMessage: 'Name', | ||
}), | ||
[RightSidebarScrollField.Description]: i18n.translate( | ||
'workspace.form.summary.panel.description.title', | ||
{ | ||
defaultMessage: 'Description', | ||
} | ||
), | ||
[RightSidebarScrollField.Color]: i18n.translate('workspace.form.summary.panel.color.title', { | ||
defaultMessage: 'Accent color', | ||
}), | ||
[RightSidebarScrollField.DataSource]: i18n.translate( | ||
'workspace.form.summary.panel.dataSources.title', | ||
{ | ||
defaultMessage: 'Data sources', | ||
} | ||
), | ||
[RightSidebarScrollField.Member]: i18n.translate( | ||
'workspace.form.summary.panel.members.title', | ||
{ | ||
defaultMessage: 'Members', | ||
} | ||
), | ||
}[field]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: maybe can just make it a constant, then use it at where it's needed with SCROLL_FIELDS[field]
return { | |
[RightSidebarScrollField.UseCase]: i18n.translate( | |
'workspace.form.summary.panel.useCase.title', | |
{ | |
defaultMessage: 'Use case', | |
} | |
), | |
[RightSidebarScrollField.Name]: i18n.translate('workspace.form.summary.panel.name.title', { | |
defaultMessage: 'Name', | |
}), | |
[RightSidebarScrollField.Description]: i18n.translate( | |
'workspace.form.summary.panel.description.title', | |
{ | |
defaultMessage: 'Description', | |
} | |
), | |
[RightSidebarScrollField.Color]: i18n.translate('workspace.form.summary.panel.color.title', { | |
defaultMessage: 'Accent color', | |
}), | |
[RightSidebarScrollField.DataSource]: i18n.translate( | |
'workspace.form.summary.panel.dataSources.title', | |
{ | |
defaultMessage: 'Data sources', | |
} | |
), | |
[RightSidebarScrollField.Member]: i18n.translate( | |
'workspace.form.summary.panel.members.title', | |
{ | |
defaultMessage: 'Members', | |
} | |
), | |
}[field]; | |
const SCROLL_FIELDS = { | |
[RightSidebarScrollField.UseCase]: i18n.translate( | |
'workspace.form.summary.panel.useCase.title', | |
{ | |
defaultMessage: 'Use case', | |
} | |
), | |
[RightSidebarScrollField.Name]: i18n.translate('workspace.form.summary.panel.name.title', { | |
defaultMessage: 'Name', | |
}), | |
[RightSidebarScrollField.Description]: i18n.translate( | |
'workspace.form.summary.panel.description.title', | |
{ | |
defaultMessage: 'Description', | |
} | |
), | |
[RightSidebarScrollField.Color]: i18n.translate('workspace.form.summary.panel.color.title', { | |
defaultMessage: 'Accent color', | |
}), | |
[RightSidebarScrollField.DataSource]: i18n.translate( | |
'workspace.form.summary.panel.dataSources.title', | |
{ | |
defaultMessage: 'Data sources', | |
} | |
), | |
[RightSidebarScrollField.Member]: i18n.translate( | |
'workspace.form.summary.panel.members.title', | |
{ | |
defaultMessage: 'Members', | |
} | |
), | |
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, will update.
8e1f1e9
to
60d235b
Compare
60d235b
to
fc002b0
Compare
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
fc002b0
to
6294070
Compare
* Move workspace form inside workspace creator Signed-off-by: Lin Wang <[email protected]> * Remove enter details panel Signed-off-by: Lin Wang <[email protected]> * Rename workspace_form to workspace_creator_form Signed-off-by: Lin Wang <[email protected]> * Clarify workspace form types Signed-off-by: Lin Wang <[email protected]> * Add right sidebar to workspace creator Signed-off-by: Lin Wang <[email protected]> * Add submitting lock for workspace create page Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7750 created/updated * Fix form submitting lock not been covered Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 76d7a8b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Move workspace form inside workspace creator * Remove enter details panel * Rename workspace_form to workspace_creator_form * Clarify workspace form types * Add right sidebar to workspace creator * Add submitting lock for workspace create page * Changeset file for PR #7750 created/updated * Fix form submitting lock not been covered --------- (cherry picked from commit 76d7a8b) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR is for adding workspace right sidebar to workspace create form. Mainly includes below changes:
workspace_form
insideworkspace_creator
folderIssues Resolved
#7765
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration