[Manual Backport 2.x] refactor: simplify theme configuration and defaulting (#7625) #7746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #7625
Signed-off-by: Viraj Sanghvi [email protected]
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit bcdbbef)
Description
The backport failed because user specific themes was pulled from 2.x. Some feedback says it was due to the UX, #6978 says due to testing, and others because it caused a blank white screen. Because I'm not sure that'll get resolved, I changed my PR to handle the differences.
The main callouts are that:
docs/theme.md
even though the base isn't present as it still seems validIssues Resolved
N/A
Screenshot
N/A
Testing the changes
I was able to switch between themes locally, validated correct css files load. Pages look correct and no errors.
Changelog
Check List
yarn test:jest
yarn test:jest_integration