Update Recent popover to always render breadcrumbs with full length #7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhongnan Su <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
github-actions
bot
added
failed changeset
Skip-Changelog
zhongnansu
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
|
The last leaf should not be clickable, and not have a trailing slash ( |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7735 +/- ##
==========================================
- Coverage 63.82% 63.78% -0.04%
==========================================
Files 3650 3650
Lines 80966 80965 -1
Branches 12894 12894
==========================================
- Hits 51673 51640 -33
- Misses 26126 26156 +30
- Partials 3167 3169 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
approved these changes
Aug 16, 2024
virajsanghvi
approved these changes
Aug 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 17, 2024
…7735) Signed-off-by: Zhongnan Su <[email protected]> (cherry picked from commit 389ad1b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Aug 19, 2024
…7735) (#7742) (cherry picked from commit 389ad1b) Signed-off-by: Zhongnan Su <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 20, 2024
…pensearch-project#7735) Signed-off-by: Zhongnan Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Recent popover to always render breadcrumbs with full length, no matter of header variants. While for page header, also keep the existing breadcrumbs on the top, with last leaf cut off
Issues Resolved
Screenshot
iShot_2024-08-16_11.49.18.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration