Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Simplify TopNavControlDescriptionData to to be followed by links #7724

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d447c5d from #7723.

…7723)

* Simplify `TopNavControlDescriptionData` to to be followed by links

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #7723 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d447c5d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (b3078c4) to head (b5a73ca).
Report is 9 commits behind head on 2.x.

Files Patch % Lines
...ation/public/top_nav_menu/top_nav_control_item.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7724      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files        3646     3646              
  Lines       80751    80753       +2     
  Branches    12842    12843       +1     
==========================================
  Hits        51528    51528              
- Misses      26067    26068       +1     
- Partials     3156     3157       +1     
Flag Coverage Δ
Linux_1 29.88% <0.00%> (-0.01%) ⬇️
Linux_2 55.94% <ø> (ø)
Linux_3 40.51% <0.00%> (-0.01%) ⬇️
Linux_4 31.46% <0.00%> (-0.01%) ⬇️
Windows_1 29.89% <0.00%> (-0.01%) ⬇️
Windows_2 55.89% <ø> (ø)
Windows_3 40.51% <0.00%> (-0.01%) ⬇️
Windows_4 31.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 95c9f3a into 2.x Aug 19, 2024
66 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor failed changeset v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants