-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspaces]Add features in use case card and preselect first use case #7703
[Workspaces]Add features in use case card and preselect first use case #7703
Conversation
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7703 +/- ##
==========================================
+ Coverage 63.80% 63.82% +0.02%
==========================================
Files 3656 3658 +2
Lines 81205 81263 +58
Branches 12949 12963 +14
==========================================
+ Hits 51809 51866 +57
- Misses 26215 26216 +1
Partials 3181 3181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
{application && | ||
savedObjects && | ||
// Default values only worked for component mount, should wait for isOnlyAllowEssential and availableUseCases loaded | ||
isOnlyAllowEssential !== undefined && | ||
availableUseCases !== undefined && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe assign this to a readable name?
{application && | |
savedObjects && | |
// Default values only worked for component mount, should wait for isOnlyAllowEssential and availableUseCases loaded | |
isOnlyAllowEssential !== undefined && | |
availableUseCases !== undefined && ( | |
{application && | |
savedObjects && | |
// Default values only worked for component mount, should wait for isOnlyAllowEssential and availableUseCases loaded | |
isOnlyAllowEssential !== undefined && | |
availableUseCases !== undefined && ( |
const result = await getIsOnlyAllowEssentialUseCase(savedObjects.client); | ||
updateEssential(result); | ||
} catch (e) { | ||
// Set to false is failed to fetch is only allow essential use case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't sound correct.
Signed-off-by: Lin Wang <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7703-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 446aa08b9730ecd4bfcbbb13e796be932ad29e7a
# Push it to GitHub
git push --set-upstream origin backport/backport-7703-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
#7703) * Display features in workspace use case card Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7703 created/updated * Changeset file for PR #7703 created/updated * Changeset file for PR #7703 created/updated * Add more test cases Signed-off-by: Lin Wang <[email protected]> * Update snapshort of workspace list Signed-off-by: Lin Wang <[email protected]> * Address pr comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 446aa08) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7703-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 446aa08b9730ecd4bfcbbb13e796be932ad29e7a
# Push it to GitHub
git push --set-upstream origin backport/backport-7703-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
#7703) (#7838) * Display features in workspace use case card * Changeset file for PR #7703 created/updated * Changeset file for PR #7703 created/updated * Changeset file for PR #7703 created/updated * Add more test cases * Update snapshort of workspace list * Address pr comments --------- (cherry picked from commit 446aa08) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR is for adding features to workspace use case card in the workspace form and preselect the first use case in the workspace create page. They mainly includes below changes:
Issues Resolved
#7705
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration