Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Refactor 'Associate data sources' to support multi-select #7696

Conversation

Kapian1234
Copy link
Contributor

@Kapian1234 Kapian1234 commented Aug 13, 2024

Description

Refactor 'Associate data sources' to support multi-select

Issues Resolved

Screenshot

Screenshot 2024-08-13 at 17 18 24

Screenshot 2024-08-21 at 14 38 46 Screenshot 2024-08-21 at 14 39 59

Testing the changes

Changelog

  • feat: refactor Associate data sources to support multi-select

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (b4ae264) to head (36ead14).

Files Patch % Lines
...e_form/createpage_opensearch_connections_table.tsx 90.90% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7696   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files        3656     3657    +1     
  Lines       81190    81200   +10     
  Branches    12945    12947    +2     
=======================================
+ Hits        51794    51802    +8     
- Misses      26217    26219    +2     
  Partials     3179     3179           
Flag Coverage Δ
Linux_1 30.07% <93.75%> (+0.01%) ⬆️
Linux_2 55.87% <ø> (ø)
Linux_3 40.42% <ø> (-0.01%) ⬇️
Linux_4 31.28% <ø> (ø)
Windows_1 30.08% <93.75%> (+0.01%) ⬆️
Windows_2 55.82% <ø> (ø)
Windows_3 40.42% <ø> (ø)
Windows_4 31.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kapian1234 <[email protected]>
…an1234/OpenSearch-Dashboards into workspace_selectDataSourcePanel_dev
SuZhou-Joe
SuZhou-Joe previously approved these changes Aug 15, 2024
@Kapian1234 Kapian1234 marked this pull request as draft August 16, 2024 02:28
@Kapian1234 Kapian1234 marked this pull request as ready for review August 21, 2024 07:33
Signed-off-by: Kapian1234 <[email protected]>
…an1234/OpenSearch-Dashboards into workspace_selectDataSourcePanel_dev
@ruanyl
Copy link
Member

ruanyl commented Aug 23, 2024

@Kapian1234 could you please resolve the conflicts? thanks!

@Kapian1234 Kapian1234 marked this pull request as draft August 27, 2024 01:48
@sejli
Copy link
Member

sejli commented Aug 30, 2024

@Kapian1234 is this still targeted for 2.17?

@Kapian1234 Kapian1234 closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants