Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: card section and dashboards section UX improvements #7693

Merged

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Aug 13, 2024

Description

Allow card section to scroll, for example with

{
  id: SECTIONS.GET_STARTED,
  order: 1000,
  title: 'Define your path forward with OpenSearch',
  kind: 'card',
+ columns: 3,
+ wrap: false,
}
Screen.Recording.2024-08-13.at.16.25.54.mov

Allow card section to wrap, for example with

{
  id: SECTIONS.GET_STARTED,
  order: 1000,
  title: 'Define your path forward with OpenSearch',
  kind: 'card',
+ columns: 3,
+ wrap: true,
}

image

Allow to customize dashboards embeddable panel size

  contentManagement.registerContentProvider({
    id: 'whats_new_cards',
    getContent: () => ({
      id: 'whats_new',
      kind: 'custom',
      order: 3,
+     width: 24,
+     height: 20,
      render: () =>
        React.createElement(HomeListCard, {
          config: WHATS_NEW_CONFIG,
        }),
    }),
    getTargetArea: () => HOME_CONTENT_AREAS.SERVICE_CARDS,
  });

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: [contentManagement] allow to customize card section columns and dashboards panel size

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (b68754e) to head (1336179).
Report is 26 commits behind head on main.

Files Patch % Lines
...ent/public/components/card_container/card_list.tsx 0.00% 6 Missing and 1 partial ⚠️
...tent_management/public/components/section_input.ts 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7693      +/-   ##
==========================================
- Coverage   63.74%   63.74%   -0.01%     
==========================================
  Files        3637     3637              
  Lines       80444    80458      +14     
  Branches    12792    12797       +5     
==========================================
+ Hits        51280    51285       +5     
- Misses      26030    26037       +7     
- Partials     3134     3136       +2     
Flag Coverage Δ
Linux_1 29.82% <7.40%> (-0.01%) ⬇️
Linux_2 55.82% <ø> (ø)
Linux_3 40.38% <59.25%> (-0.01%) ⬇️
Linux_4 31.28% <7.40%> (-0.01%) ⬇️
Windows_1 29.84% <7.40%> (-0.01%) ⬇️
Windows_2 55.77% <ø> (ø)
Windows_3 40.39% <59.25%> (+<0.01%) ⬆️
Windows_4 31.28% <7.40%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl force-pushed the content-management-minor-improvements branch from cd2c2ce to 1336179 Compare August 13, 2024 09:10
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ruanyl ruanyl merged commit a258bd6 into opensearch-project:main Aug 21, 2024
72 of 73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 21, 2024
Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit a258bd6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 21, 2024
)

(cherry picked from commit a258bd6)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants