Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace][Bug] Unable to copy assets to a workspace without assigning related data source #7690

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Aug 13, 2024

Description

Copy assets from one workspace to another will not be allowed if the data source doesn't exist in target workspace.

Issues Resolved

Screenshot

2024-11-11.16.09.02.mp4

Testing the changes

Changelog

  • fix: [Workspace] Unable to copy assets to a workspace without assigning related data source

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.89%. Comparing base (9f23442) to head (06cd3ee).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rver/saved_objects/import/validate_data_sources.ts 90.00% 0 Missing and 2 partials ⚠️
...jects_table/components/duplicate_result_flyout.tsx 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7690      +/-   ##
==========================================
+ Coverage   60.87%   60.89%   +0.01%     
==========================================
  Files        3808     3809       +1     
  Lines       91209    91281      +72     
  Branches    14410    14425      +15     
==========================================
+ Hits        55526    55587      +61     
- Misses      32142    32154      +12     
+ Partials     3541     3540       -1     
Flag Coverage Δ
Linux_1 28.99% <3.40%> (-0.03%) ⬇️
Linux_2 56.46% <95.55%> (+0.07%) ⬆️
Linux_3 ?
Linux_4 29.03% <45.88%> (+0.01%) ⬆️
Windows_1 29.00% <3.40%> (-0.05%) ⬇️
Windows_2 56.41% <95.55%> (+0.07%) ⬆️
Windows_3 37.89% <0.00%> (-0.05%) ⬇️
Windows_4 29.03% <45.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yubonluo yubonluo requested a review from huyaboo as a code owner September 14, 2024 03:50
@ruanyl
Copy link
Member

ruanyl commented Oct 29, 2024

@yubonluo Could you please resolve the conflicts? Thank you :)

@yubonluo yubonluo force-pushed the 2.17/show-error-for-SO-unassigned-DS branch from 8ef2978 to 91fdbe6 Compare November 11, 2024 08:04
Signed-off-by: yubonluo <[email protected]>
@yubonluo yubonluo changed the title [Workspace][Bug] Show error for saved objects which unassigned related data source [Workspace][Bug] Unable to copy assets to a workspace without assigning related data source Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants