Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 query bar refactoring #7667

Closed
wants to merge 9 commits into from

Conversation

abbyhu2000
Copy link
Member

Description

  • new language manager to handle query enhancement and query extension and query editor UI related settings
  • unify storage service within data plugin
  • add recent query history service
  • query bar UI 2.0

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Aug 8, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 22.35294% with 66 lines in your changes missing coverage. Please review.

Project coverage is 63.63%. Comparing base (7c14589) to head (c51462e).
Report is 132 commits behind head on main.

Files with missing lines Patch % Lines
.../plugins/data/public/query/query_string/history.ts 13.04% 19 Missing and 1 partial ⚠️
src/plugins/data/public/ui/history/storage.ts 0.00% 17 Missing ⚠️
.../public/query/query_string/query_string_manager.ts 38.46% 8 Missing ⚠️
src/plugins/data/public/ui/settings/settings.ts 11.11% 8 Missing ⚠️
.../query_string/language_manager/language_manager.ts 41.66% 7 Missing ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx 40.00% 3 Missing ⚠️
src/plugins/data/public/plugin.ts 0.00% 2 Missing ⚠️
...s/data/public/query/persisted_log/persisted_log.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7667      +/-   ##
==========================================
- Coverage   63.66%   63.63%   -0.03%     
==========================================
  Files        3632     3636       +4     
  Lines       80060    80176     +116     
  Branches    12683    12700      +17     
==========================================
+ Hits        50967    51024      +57     
- Misses      25987    26045      +58     
- Partials     3106     3107       +1     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.59% <ø> (+<0.01%) ⬆️
Linux_4 31.27% <2.53%> (-0.04%) ⬇️
Windows_1 30.58% <1.26%> (+0.01%) ⬆️
Windows_2 55.54% <ø> (+<0.01%) ⬆️
Windows_3 40.52% <22.35%> (-0.05%) ⬇️
Windows_4 31.27% <2.53%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants