Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix browser warnings #7661

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ca89488 from #7550.

* fix warnings

Signed-off-by: Kapian1234 <[email protected]>

* fix warnings

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #7548 created/updated

* fix warnings

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #7550 created/updated

* Modified the expect of addNavLinksToGroup in workspace plugin.test.js

Signed-off-by: Kapian1234 <[email protected]>

* Modified the expect of addNavLinksToGroup in workspace plugin.test.js

Signed-off-by: Kapian1234 <[email protected]>

* remove the duplicate changelogs

Signed-off-by: Kapian1234 <[email protected]>

* Renamed keys to comply with the directory the file is in

Signed-off-by: Kapian1234 <[email protected]>

---------

Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Jincheng Wan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit ca89488)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Aug 8, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (d7f3765) to head (4211c7d).

Files Patch % Lines
...rc/plugins/home/public/application/home_render.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7661      +/-   ##
==========================================
- Coverage   63.74%   63.74%   -0.01%     
==========================================
  Files        3633     3633              
  Lines       80092    80091       -1     
  Branches    12673    12673              
==========================================
- Hits        51058    51057       -1     
  Misses      25933    25933              
  Partials     3101     3101              
Flag Coverage Δ
Linux_1 30.57% <0.00%> (-0.01%) ⬇️
Linux_2 55.70% <ø> (ø)
Linux_3 40.63% <33.33%> (ø)
Linux_4 31.46% <33.33%> (ø)
Windows_1 30.59% <0.00%> (-0.01%) ⬇️
Windows_2 55.65% <ø> (ø)
Windows_3 40.63% <33.33%> (ø)
Windows_4 31.46% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 5b1e0f0 into 2.x Aug 9, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset first-time-contributor v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants