fix: get start section cards not aligned #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The column size was hard coded to 4 previously, not changed so that it can be configured, this addressed the issue when there are more than 4 cards, cards will be displayed in multiple rows Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7624 +/- ##
==========================================
- Coverage 63.66% 63.66% -0.01%
==========================================
Files 3632 3632
Lines 80060 80061 +1
Branches 12683 12684 +1
==========================================
Hits 50967 50967
Misses 25987 25987
- Partials 3106 3107 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe
approved these changes
Aug 6, 2024
ananzh
approved these changes
Aug 6, 2024
TackAdam
approved these changes
Aug 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* fix: get start section cards not aligned The column size was hard coded to 4 previously, not changed so that it can be configured, this addressed the issue when there are more than 4 cards, cards will be displayed in multiple rows Signed-off-by: Yulong Ruan <[email protected]> * fix ts type Signed-off-by: Yulong Ruan <[email protected]> * tweaks types Signed-off-by: Yulong Ruan <[email protected]> * add a todo item Signed-off-by: Yulong Ruan <[email protected]> * fix license header Signed-off-by: Yulong Ruan <[email protected]> * Changeset file for PR #7624 created/updated --------- Signed-off-by: Yulong Ruan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit aa807e5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 9, 2024
* fix: get start section cards not aligned The column size was hard coded to 4 previously, not changed so that it can be configured, this addressed the issue when there are more than 4 cards, cards will be displayed in multiple rows * fix ts type * tweaks types * add a todo item * fix license header * Changeset file for PR #7624 created/updated --------- (cherry picked from commit aa807e5) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column size was hard coded to 4 previously, now changed so that it can be configured, this addressed the issue when there are more than 4 cards, cards will be displayed in multiple rows
Description
Before
After
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration