Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.16 release notes #7561

Closed
wants to merge 2 commits into from
Closed

2.16 release notes #7561

wants to merge 2 commits into from

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Jul 29, 2024 •
edited
Loading

Description

The PR adds 2.16 Release Notes and changelogs.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added failed changeset Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 29, 2024
@LDrago27 LDrago27 added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (2d8c743) to head (cd15383).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7561      +/-   ##
==========================================
- Coverage   63.65%   63.64%   -0.02%     
==========================================
  Files        3629     3629              
  Lines       79519    79522       +3     
  Branches    12602    12604       +2     
==========================================
- Hits        50618    50611       -7     
- Misses      25834    25842       +8     
- Partials     3067     3069       +2
Flag Coverage Δ
Linux_1 30.76% <ø> (-0.01%) ⬇️
Linux_2 55.58% <ø> (ø)
Linux_3 40.22% <ø> (-0.02%) ⬇️
Linux_4 31.57% <ø> (-0.01%) ⬇️
Windows_1 30.77% <ø> (-0.01%) ⬇️
Windows_2 55.53% <ø> (ø)
Windows_3 40.23% <ø> (-0.02%) ⬇️
Windows_4 31.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ananzh
ananzh reviewed Jul 30, 2024
View reviewed changes
src/dev/generate_release_note.ts
@@ -73,8 +73,17 @@ async function readFragments() {

validateFragment(fragmentContents);

const fragmentYaml = loadYaml(fragmentContents) as Changelog;
const fragmentContentLines = fragmentContents.split('\n');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the fix

ananzh
ananzh reviewed Jul 30, 2024
View reviewed changes
release-notes/opensearch-dashboards.release-notes-3.0.0.md Outdated
@@ -0,0 +1,192 @@
# VERSION 3.0.0 Release Note
Copy link
Member

@ananzh ananzh Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 2.16.0? the same question for the file name 😆 😆 😆

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the Issue.

release-notes/opensearch-dashboards.release-notes-3.0.0.md Outdated

### 🛡 Security

- [CVE-2024-28863] Bump tar from 6.1.11 to 6.2.1 ([#6492](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6492))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I see there are styles inconsistent
[CVE-2024-28863] Bump tar from 6.1.11 to 6.2.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could define a style like the above and ask LLM to fix the rest and check typos.

@LDrago27
Add 2.16 Release Notes
cd15383 
Signed-off-by: Suchit Sahoo <[email protected]>
@ananzh
Copy link
Member

ananzh commented Jul 30, 2024

Do we need to include other PRs that are still not merged in? Let's add them tmrw?

@ruanyl
Copy link
Member

ruanyl commented Jul 30, 2024

Should release notes generated on release branch(2.16) and merged to release branch first and then backport to main? Are you generating the release notes on main branch?

@prudhvigodithi prudhvigodithi mentioned this pull request Jul 30, 2024
Closed
74 tasks
@LDrago27
Copy link
Collaborator Author

Closing it will open a new PR with updated Notes

@LDrago27 LDrago27 closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
backport 2.x failed changeset seasoned-contributor v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LDrago27 @ananzh @ruanyl