[navigation]fix: redirect user to home in global when workspace is enabled #7551

SuZhou-Joe · 2024-07-29T10:25:59Z

Description

When workspace is enabled, users are not supposed to create any objects in global, thus the new left navigation need to redirect users to home, and in home, user won't be able to expand the left navigation.

Change the back to home when user is in settings and setup / data administration nav groups.
Change the navGroup to dataAdministration when navigate to devTools.

Issues Resolved

Screenshot

Before fix

Before the fix, you can see users is able to go into all use case and create objects in global.

20240729183432978.mp4

After fix

User will be redirect to home.

20240729183633650.mp4

Testing the changes

Enable workspace feature flag
Goes to settings and setup
Expand the left navigation

Changelog

fix: [navigation]feat: redirect user to home in global when workspace is enabled

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <[email protected]>

codecov · 2024-07-29T10:54:35Z

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.64%. Comparing base (5f19c37) to head (30b375b).
Report is 491 commits behind head on main.

Files with missing lines	Patch %	Lines
...me/ui/header/collapsible_nav_group_enabled_top.tsx	76.92%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7551   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        3629     3630    +1     
  Lines       79522    79535   +13     
  Branches    12604    12608    +4     
=======================================
+ Hits        50611    50620    +9     
- Misses      25842    25844    +2     
- Partials     3069     3071    +2

Flag	Coverage Δ
Linux_1	`30.75% <0.00%> (-0.01%)`	⬇️
Linux_2	`55.58% <81.25%> (+<0.01%)`	⬆️
Linux_3	`40.21% <11.11%> (-0.01%)`	⬇️
Linux_4	`31.56% <0.00%> (-0.01%)`	⬇️
Windows_1	`30.77% <0.00%> (-0.01%)`	⬇️
Windows_2	`55.53% <81.25%> (+<0.01%)`	⬆️
Windows_3	`40.22% <11.11%> (-0.01%)`	⬇️
Windows_4	`31.56% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <[email protected]>

ruanyl · 2024-07-30T09:41:23Z

src/plugins/dev_tools/public/dev_tools_icon.test.tsx

+import { DEFAULT_NAV_GROUPS } from '../../../core/public';
+
+describe('<DevToolsIcon />', () => {
+  it('should call some methods from core service when click', () => {


Nit: better to elaborate what's the some methods

Sure, updated.

src/core/public/chrome/ui/header/collapsible_nav_group_enabled_top.tsx

Signed-off-by: SuZhou-Joe <[email protected]>

…abled (#7551) * feat: redirect user to home when in global Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7551 created/updated * Changeset file for PR #7551 created/updated * feat: add some comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless change Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize description and variable naming Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> (cherry picked from commit 96936f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…abled (#7551) (#7572) * feat: redirect user to home when in global * Changeset file for PR #7551 created/updated * Changeset file for PR #7551 created/updated * feat: add some comment * feat: remove useless change * feat: optimize comment * feat: optimize description and variable naming * feat: update --------- (cherry picked from commit 96936f3) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]>

…abled (opensearch-project#7551) * feat: redirect user to home when in global Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR opensearch-project#7551 created/updated * Changeset file for PR opensearch-project#7551 created/updated * feat: add some comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless change Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize description and variable naming Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]>

SuZhou-Joe requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27, virajsanghvi and sejli as code owners July 29, 2024 10:26

github-actions bot added all-star-contributor failed changeset and removed failed changeset labels Jul 29, 2024

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 29, 2024

Changeset file for PR opensearch-project#7551 created/updated

d8bb497

SuZhou-Joe added bug Something isn't working backport 2.x v2.16.0 backport 2.16 labels Jul 29, 2024

SuZhou-Joe changed the title ~~[navigation]feat: redirect user to home in global when workspace is enabled~~ [navigation]fix: redirect user to home in global when workspace is enabled Jul 29, 2024

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 29, 2024

Changeset file for PR opensearch-project#7551 created/updated

74de06a

opensearch-project deleted a comment from github-actions bot Jul 29, 2024

SuZhou-Joe and others added 5 commits July 29, 2024 18:40

feat: redirect user to home when in global

11bac23

Signed-off-by: SuZhou-Joe <[email protected]>

Changeset file for PR opensearch-project#7551 created/updated

053f62e

Changeset file for PR opensearch-project#7551 created/updated

0c3aa9f

feat: add some comment

8798bf7

Signed-off-by: SuZhou-Joe <[email protected]>

feat: remove useless change

d43fdac

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the fix/top-nav-back branch from c90f169 to d43fdac Compare July 29, 2024 10:40

feat: optimize comment

00da116

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe requested a review from joshuali925 as a code owner July 29, 2024 21:38

Merge branch 'main' into fix/top-nav-back

b4790c5

ruanyl reviewed Jul 30, 2024

View reviewed changes

feat: optimize description and variable naming

dd669d9

Signed-off-by: SuZhou-Joe <[email protected]>

ruanyl previously approved these changes Jul 30, 2024

View reviewed changes

feat: update

30b375b

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe dismissed ruanyl’s stale review via 30b375b July 30, 2024 10:14

ruanyl approved these changes Jul 30, 2024

View reviewed changes

ananzh approved these changes Jul 30, 2024

View reviewed changes

ananzh merged commit 96936f3 into opensearch-project:main Jul 30, 2024
67 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 30, 2024

[Backport 2.x] [navigation]fix: redirect user to home in global when workspace is enabled #7572

Merged

opensearch-trigger-bot bot mentioned this pull request Jul 30, 2024

[Backport 2.16] [navigation]fix: redirect user to home in global when workspace is enabled #7573

Closed

SuZhou-Joe added the navigation label Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation]fix: redirect user to home in global when workspace is enabled #7551

[navigation]fix: redirect user to home in global when workspace is enabled #7551

SuZhou-Joe commented Jul 29, 2024 •

edited

Loading

codecov bot commented Jul 29, 2024 •

edited

Loading

ruanyl Jul 30, 2024

SuZhou-Joe Jul 30, 2024

[navigation]fix: redirect user to home in global when workspace is enabled #7551

[navigation]fix: redirect user to home in global when workspace is enabled #7551

Conversation

SuZhou-Joe commented Jul 29, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Before fix

After fix

Testing the changes

Changelog

Check List

codecov bot commented Jul 29, 2024 • edited Loading

Codecov Report

ruanyl Jul 30, 2024

Choose a reason for hiding this comment

SuZhou-Joe Jul 30, 2024

Choose a reason for hiding this comment

SuZhou-Joe commented Jul 29, 2024 •

edited

Loading

codecov bot commented Jul 29, 2024 •

edited

Loading