-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Support getting workspace client from coreStart #7501
[Workspace] Support getting workspace client from coreStart #7501
Conversation
d2320cd
to
7566a22
Compare
Signed-off-by: yubonluo <[email protected]>
862494c
to
df7f4e9
Compare
Signed-off-by: yubonluo <[email protected]>
…OpenSearch-Dashboards into 2.17-optimize-workspace-client
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7501 +/- ##
=======================================
Coverage 63.81% 63.81%
=======================================
Files 3651 3650 -1
Lines 80954 80966 +12
Branches 12893 12894 +1
=======================================
+ Hits 51662 51671 +9
- Misses 26126 26127 +1
- Partials 3166 3168 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <[email protected]>
…OpenSearch-Dashboards into 2.17/optimize-workspace-client
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7501-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ae7cfa6072957ac2068807618a02804321731c2f
# Push it to GitHub
git push --set-upstream origin backport/backport-7501-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…ch-project#7501) * Support to get workspace client from coreStart Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#7501 created/updated * Support to get workspace client from coreStart Signed-off-by: yubonluo <[email protected]> * fix test error Signed-off-by: yubonluo <[email protected]> * delete irrelevant modification Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
* Support to get workspace client from coreStart Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7501 created/updated * Support to get workspace client from coreStart Signed-off-by: yubonluo <[email protected]> * fix test error Signed-off-by: yubonluo <[email protected]> * delete irrelevant modification Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit ae7cfa6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…7797) * Support to get workspace client from coreStart * Changeset file for PR #7501 created/updated * Support to get workspace client from coreStart * fix test error * delete irrelevant modification * optimize the code * optimize the code * optimize the code --------- (cherry picked from commit ae7cfa6) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Description
Support getting workspace client from coreStart.
Expose a workspace client interface, which can be implemented by the workspace client:
Other plugins can get workspace client from coreStart:
Currently, this interface exposes a copy method, which can be used by other plugin:
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration