fix(discover): truncate height of table cell

[joshuali925]

Description

see #7176. osdDocTable__limitedHeight class isn't associated with any style, use truncate-by-height to truncate.

@AMoo-Miki osdDocTable__limitedHeight was added in 1ba45a7, any concerns with this?

Issues Resolved

closes #7176

Screenshot

before

after

Testing the changes

Changelog

• fix: truncate height of table cell in legacy discover

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (e0945af) to head (00230f8).
Report is 320 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7178      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.01%     
==========================================
  Files        3469     3469              
  Lines       68508    68479      -29     
  Branches    11141    11130      -11     
==========================================
- Hits        46289    46264      -25     
+ Misses      19514    19512       -2     
+ Partials     2705     2703       -2     

Flag	Coverage Δ
Linux_1	33.13% <ø> (-0.04%)	⬇️
Linux_2	55.26% <ø> (+<0.01%)	⬆️
Linux_3	45.31% <ø> (-0.01%)	⬇️
Linux_4	34.71% <ø> (-0.02%)	⬇️
Windows_1	33.15% <ø> (-0.04%)	⬇️
Windows_2	55.21% <ø> (+<0.01%)	⬆️
Windows_3	45.32% <ø> (-0.01%)	⬇️
Windows_4	34.71% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AMoo-Miki]

Looks like some things are missing from #5766

I remember we decided against using clamp in favor of the value from Advanced Settings. I remember some match written to handle this but a quick search doesn't bring it up.

The reason for the new math is that truncate-by-height uses an injector from legacy which we are trying to get rid of. However, now that that math is not in the code, let's use truncate-by-height and deal with it later.

[joshuali925]

got it

I remember we decided against using clamp in favor of the value from Advanced Settings

i think supporting value from advanced settings is a new feature, but right now it doesn't truncate at all which is a bug/regression. we can fix the bug first to improve readability for users, then improve it by implementing the feature and remove legacy stuff

[iaroslavkorablev]

Could you please tell me - in which version of Opensearch Dashboards is this fix planned to be released?

Or is it already included in one of the versions ? 2.17.0 or 2.17.1.

Very much waiting for this fix, so I thought I'd ask. Thanks for the answer!

[iaroslavkorablev]

@ashwin-pc @joshuali925 @AMoo-Miki
I'm sorry to bother you, could you give me a hint, please? I'd be very grateful.

Could you please tell me - in which version of Opensearch Dashboards is this fix planned to be released?

Or is it already included in one of the versions ? 2.17.0 or 2.17.1.

Very much waiting for this fix, so I thought I'd ask. Thanks for the answer!

[joshuali925]

@iaroslavkorablev it's labeled 2.17.1 but git tag 2.17.1 doesn't have this

OpenSearch-Dashboards/src/plugins/discover/public/application/components/default_discover_table/table_cell.tsx

Line 88 in 62cc032

<div className="osdDocTable__limitedHeight">{content}</div>

if there's no 2.17.2, then it will be released in 2.18.0

[iaroslavkorablev]

@iaroslavkorablev it's labeled 2.17.1 but git tag 2.17.1 doesn't have this

OpenSearch-Dashboards/src/plugins/discover/public/application/components/default_discover_table/table_cell.tsx

Line 88 in 62cc032

<div className="osdDocTable__limitedHeight">{content}</div>

if there's no 2.17.2, then it will be released in 2.18.0

thank you very much for your reply

[iaroslavkorablev]

@ashwin-pc @joshuali925 @AMoo-Miki
I'm sorry to bother you,
could you please kindly confirm if the change has been included in version 2.18.0?

[joshuali925]

@iaroslavkorablev checking the 2.18.0 release notes it does include this PR, so it is fixed in 2.18.0

OpenSearch-Dashboards/release-notes/opensearch-dashboards.release-notes-2.18.0.md

Line 77 in 696b792

- Truncate height of table cell in legacy discover ([#7178](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7178))

if it's not working for you, you can try to clear browser cache first or open a new issue here

[iaroslavkorablev]

@iaroslavkorablev checking the 2.18.0 release notes it does include this PR, so it is fixed in 2.18.0

OpenSearch-Dashboards/release-notes/opensearch-dashboards.release-notes-2.18.0.md

Line 77 in 696b792

- Truncate height of table cell in legacy discover ([#7178](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7178))

if it's not working for you, you can try to clear browser cache first or open a new issue here

thank you very much