[Backport 2.x] [Data Explorer] Fix share link of save search #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit e1db842) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
de-angular
opensearch-trigger-bot
bot
added
Skip-Changelog
opensearch-trigger-bot
bot
requested a review
from seanneumann
as a code owner
opensearch-trigger-bot
bot
requested review from
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #5329 +/- ##
=======================================
Coverage 66.81% 66.81%
=======================================
Files 3284 3284
Lines 63149 63149
Branches 10048 10048
=======================================
Hits 42192 42192
Misses 18485 18485
Partials 2472 2472
Flags with carried forward coverage won't be shown. Click here to find out more. |
manasvinibs
approved these changes
Oct 19, 2023
[MANUAL CYPRESS TEST RUN RESULTS]✅ Cypress test run succeeded!Inputs:Link to results:https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6579561895 |
kavilla
approved these changes
Oct 19, 2023
|
The failed shared_link cypress test passed. The remaining 2 tests should be fixed by #5300. Merged that PR, and retrigger the CI now. |
joshuarrrr
approved these changes
Oct 19, 2023
|
All CI pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e1db842 from #5324.