Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSCI] Remove unused tutorials #5212

Merged
merged 7 commits into from
Nov 7, 2023
Merged

[OSCI] Remove unused tutorials #5212

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f5ebfb
removed unused content under src/plugins/home/server/tutorials
CMDWillYang Oct 4, 2023
0ff9bc5
Merge remote-tracking branch 'origin/main'
CMDWillYang Oct 4, 2023
8417802
Merge branch 'opensearch-project:main' into main
CMDWillYang Oct 18, 2023
4b38275
removed unused svg assets under src/plugins/home/public/assets/tutori…
CMDWillYang Oct 18, 2023
451fd04
updated changelog
CMDWillYang Oct 18, 2023
271a7f2
Merge branch 'main' into main
CMDWillYang Oct 18, 2023
8761e15
Update CHANGELOG.md
CMDWillYang Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/plugins/home/server/services/tutorials/tutorials_registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import {
ScopedTutorialContextFactory,
} from './lib/tutorials_registry_types';
import { tutorialSchema } from './lib/tutorial_schema';
import { builtInTutorials } from '../../tutorials/register';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an unused import, and also the only usage of tutorials under src/plugins/home/server/tutorials

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CMDWillYang Either in this PR, or as a standalone followup, can you also delete this comment:

OpenSearch-Dashboards/src/plugins/home/server/services/tutorials/tutorials_registry.ts

Lines 97 to 100 in 0ff9bc5

// pre-populate with built in tutorials
// TODO: [RENAMEME] Need prod urls.
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/335
// this.tutorialProviders.push(...builtInTutorials);


export class TutorialsRegistry {
private tutorialProviders: TutorialProvider[] = []; // pre-register all the tutorials we know we want in here
Expand Down
77 changes: 0 additions & 77 deletions src/plugins/home/server/tutorials/activemq_logs/index.ts
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions src/plugins/home/server/tutorials/activemq_metrics/index.ts
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions src/plugins/home/server/tutorials/aerospike_metrics/index.ts
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions src/plugins/home/server/tutorials/apache_logs/index.ts
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions src/plugins/home/server/tutorials/apache_metrics/index.ts
View file
Open in desktop

This file was deleted.

Loading