Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] bump version to next patch version #5109

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 25, 2023

Description

Bump from 2.10.0 to 2.10.1

Issues Resolved

#4584

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Bump from 2.10.0 to 2.11.1

Issue resolved:
opensearch-project#4584

Signed-off-by: Kawika Avilla <[email protected]>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #5109 (f0f722c) into 2.10 (c1120d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             2.10    #5109   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files        3402     3402           
  Lines       64980    64980           
  Branches    10374    10374           
=======================================
  Hits        43197    43197           
  Misses      19219    19219           
  Partials     2564     2564           
Flag Coverage Δ
Linux_1 34.86% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 44.38% <ø> (ø)
Linux_4 35.05% <ø> (ø)
Windows_1 34.88% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 44.38% <ø> (ø)
Windows_4 35.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joshuarrrr
Copy link
Member

@kavilla What's the general plan with these? Are we expected to merge with all tests failing, or wait until the tests can pass?

@kavilla
Copy link
Member Author

kavilla commented Oct 4, 2023

@kavilla What's the general plan with these? Are we expected to merge with all tests failing, or wait until the tests can pass?

Technically part of the post release activities, we are suppose to bump the patch version. Last time I am aware the patch version bump is requirement before artifacts are generated (OpenSearch and OpenSearch Dashboards).

So these version bumps will always fail based on the current expected release workflow. However, based on a plan for release improvements and decoupling I haven't yet posted. Fallback artifacts can be utilized. Patch versions are easy because it should be the most recent patch version release OpenSearch.

Minor will be ok but we will need to configure the dev only mode a little bit. So I would say yes the current expectation is that this will fail.

However, we are planning on making it a little bit better.

@joshuarrrr joshuarrrr merged commit b889094 into opensearch-project:2.10 Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants