addressing comments

Signed-off-by: Sean Li <[email protected]>
opensearch-project · Sep 17, 2024 · 783d4b8 · 783d4b8
1 parent e8b244e
commit 783d4b8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/src/plugins/data/public/query/query_string/language_service/types.ts b/src/plugins/data/public/query/query_string/language_service/types.ts
@@ -51,5 +51,5 @@ export interface LanguageConfig {
   showDocLinks?: boolean;
   editorSupportedAppNames?: string[];
   supportedAppNames?: string[];
-  noTimeField?: boolean;
+  disableDatePicker?: boolean;
 }
diff --git a/src/plugins/data/public/ui/dataset_selector/configurator.tsx b/src/plugins/data/public/ui/dataset_selector/configurator.tsx
@@ -52,16 +52,17 @@ export const Configurator = ({
     return languages[0];
   });
 
-  const requiresTimeField = (ds: Dataset, lang: string, fields: DatasetField[]) => {
+  const displayTimeFieldSelector = (ds: Dataset, lang: string, fields: DatasetField[]) => {
     if (
-      languageService.getLanguage(lang)?.noTimeField ||
+      languageService.getLanguage(lang)?.disableDatePicker ||
       ds.type === DEFAULT_DATA.SET_TYPES.INDEX_PATTERN
     ) {
       return false;
     }
     if (fields && fields.length > 0) {
       return true;
     }
+    return false;
   };
 
   useEffect(() => {
@@ -111,7 +112,7 @@ export const Configurator = ({
             <EuiFieldText disabled value={dataset.title} />
           </EuiFormRow>
           {dataset.type === DEFAULT_DATA.SET_TYPES.INDEX_PATTERN &&
-            !languageService.getLanguage(language)?.noTimeField && (
+            !languageService.getLanguage(language)?.disableDatePicker && (
               <EuiFormRow
                 label={i18n.translate(
                   'data.explorer.datasetSelector.advancedSelector.configurator.datasetLabel',
@@ -123,7 +124,7 @@ export const Configurator = ({
                 <EuiFieldText disabled value={dataset.timeFieldName ?? 'No time field'} />
               </EuiFormRow>
             )}
-          {requiresTimeField(dataset, language, timeFields) && (
+          {displayTimeFieldSelector(dataset, language, timeFields) && (
             <EuiFormRow
               label={i18n.translate(
                 'data.explorer.datasetSelector.advancedSelector.configurator.timeFieldLabel',
@@ -147,7 +148,7 @@ export const Configurator = ({
                   setTimeFieldName(e.target.value);
                   setDataset({ ...dataset, timeFieldName: value });
                 }}
-                hasNoInitialSelection={dataset.type === DEFAULT_DATA.SET_TYPES.INDEX}
+                hasNoInitialSelection={dataset.type !== DEFAULT_DATA.SET_TYPES.INDEX_PATTERN}
               />
             </EuiFormRow>
           )}
@@ -192,7 +193,9 @@ export const Configurator = ({
             onConfirm(dataset);
           }}
           fill
-          disabled={timeFieldName === undefined && requiresTimeField(dataset, language, timeFields)}
+          disabled={
+            timeFieldName === undefined && displayTimeFieldSelector(dataset, language, timeFields)
+          }
         >
           <FormattedMessage
             id="data.explorer.datasetSelector.advancedSelector.confirm"

diff --git a/src/plugins/query_enhancements/public/plugin.tsx b/src/plugins/query_enhancements/public/plugin.tsx
@@ -100,7 +100,7 @@ export class QueryEnhancementsPlugin
       editor: enhancedSQLQueryEditor,
       editorSupportedAppNames: ['discover'],
       supportedAppNames: ['discover', 'data-explorer'],
-      noTimeField: true,
+      disableDatePicker: true,
     };
     queryString.getLanguageService().registerLanguage(sqlLanguageConfig);