Sync query and filter when refreshing discover page (#8168)

* revert back to use savedSearch Signed-off-by: abbyhu2000 <[email protected]> * change to use savedSearchId Signed-off-by: abbyhu2000 <[email protected]> * Changeset file for PR #8168 created/updated * revert to use savesearch Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 18875f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Sep 13, 2024 · 0f69bfb · 0f69bfb
1 parent 8386b12
commit 0f69bfb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/changelogs/fragments/8168.yml b/changelogs/fragments/8168.yml
@@ -0,0 +1,2 @@
+fix:
+- Sync query and filter when refreshing discover page ([#8168](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8168))
diff --git a/src/plugins/discover/public/application/view_components/utils/use_search.ts b/src/plugins/discover/public/application/view_components/utils/use_search.ts
@@ -324,6 +324,11 @@ export const useSearch = (services: DiscoverViewServices) => {
       const savedSearchInstance = await getSavedSearchById(savedSearchId);
       setSavedSearch(savedSearchInstance);
 
+      // if saved search does not exist, do not atempt to sync filters and query from savedObject
+      if (!savedSearch) {
+        return;
+      }
+
       // sync initial app filters from savedObject to filterManager
       const filters = cloneDeep(savedSearchInstance.searchSource.getOwnField('filter'));
       const query =
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		fix:
		- Sync query and filter when refreshing discover page ([#8168](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8168))