fix ts type of injectSearchSourceReferences to avoid type casting (#7725

) (#7762) (cherry picked from commit 85fae59) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Aug 20, 2024 · 006b820 · 006b820
1 parent 020c6e9
commit 006b820
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/src/plugins/data/common/search/search_source/inject_references.ts b/src/plugins/data/common/search/search_source/inject_references.ts
@@ -32,7 +32,7 @@ import { SavedObjectReference } from 'src/core/types';
 import { SearchSourceFields } from './types';
 
 export const injectReferences = (
-  searchSourceFields: SearchSourceFields & { indexRefName: string },
+  searchSourceFields: SearchSourceFields & { indexRefName?: string },
   references: SavedObjectReference[]
 ) => {
   const searchSourceReturnFields: SearchSourceFields = { ...searchSourceFields };

diff --git a/src/plugins/saved_objects/public/saved_object/helpers/apply_opensearch_resp.ts b/src/plugins/saved_objects/public/saved_object/helpers/apply_opensearch_resp.ts
@@ -91,10 +91,7 @@ export async function applyOpenSearchResp(
       let searchSourceValues = parseSearchSourceJSON(meta.searchSourceJSON);
 
       if (config.searchSource) {
-        searchSourceValues = injectSearchSourceReferences(
-          searchSourceValues as any,
-          resp.references
-        );
+        searchSourceValues = injectSearchSourceReferences(searchSourceValues, resp.references);
         savedObject.searchSource = await dependencies.search.searchSource.create(
           searchSourceValues
         );

diff --git a/src/plugins/vis_builder/public/saved_visualizations/saved_visualization_references.ts b/src/plugins/vis_builder/public/saved_visualizations/saved_visualization_references.ts
@@ -13,7 +13,7 @@ export function injectReferences(
 ) {
   if (savedObject.searchSourceFields) {
     savedObject.searchSourceFields = injectSearchSourceReferences(
-      savedObject.searchSourceFields as any,
+      savedObject.searchSourceFields,
       references
     );
   }

diff --git a/src/plugins/visualizations/public/saved_visualizations/saved_visualization_references.ts b/src/plugins/visualizations/public/saved_visualizations/saved_visualization_references.ts
@@ -97,7 +97,7 @@ export function extractReferences({
 export function injectReferences(savedObject: VisSavedObject, references: SavedObjectReference[]) {
   if (savedObject.searchSourceFields) {
     savedObject.searchSourceFields = injectSearchSourceReferences(
-      savedObject.searchSourceFields as any,
+      savedObject.searchSourceFields,
       references
     );
   }