Feature/base arch #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d private _sequence attribute
…ap around private _molecular_weight attribute
…ecular_weight attributes
sadrasabouri
approved these changes
May 22, 2024
sepandhaghighi
requested changes
May 25, 2024
There was a problem hiding this comment.
@AHReccese Thanks for your efforts 💯
The structure is simple and efficient! Please take a look at my comment. Also, please solve docstyle issues and then ping me for final review.
|
@sepandhaghighi a kind request for your review. |
sepandhaghighi
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
@AHReccese Thanks for all your hard work🔥
The basic architecture looks good to me! 💯 We can discuss other details later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?