Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edits #20

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Minor edits #20

merged 10 commits into from
Oct 9, 2024

Conversation

sepandhaghighi
Copy link
Member

@sepandhaghighi sepandhaghighi commented Oct 9, 2024 •
edited
Loading

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • MeltingTemperature enum added to __init__.py
  • molecular_weight_calc and basic_melting_temperature_calc functions moved to functions.py
  • PRIMER_MULTIPICATION_ERROR --> PRIMER_MULTIPLICATION_ERROR

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Oct 9, 2024
@sepandhaghighi sepandhaghighi added this to the opr v0.1 milestone Oct 9, 2024
AHReccese
AHReccese approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, I got the point and I will take care of such things in the next PRs.
and Since it is going to be the first release, there is no need to update CHANGELOG.md for this refactoring purposes.

LGTM

@AHReccese AHReccese merged commit db961d0 into dev Oct 9, 2024
42 checks passed
@AHReccese AHReccese deleted the minor_edits branch October 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AHReccese AHReccese AHReccese approved these changes

Assignees

@sepandhaghighi sepandhaghighi

Labels
minor refactoring
Projects
None yet
Milestone
opr v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sepandhaghighi @AHReccese