-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancements #29
enhancements #29
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #29 +/- ##
======================================
Coverage ? 72.08%
======================================
Files ? 4
Lines ? 154
Branches ? 42
======================================
Hits ? 111
Misses ? 36
Partials ? 7 ☔ View full report in Codecov by Sentry. |
@sadrasabouri |
If you can do it, let me know so I can assign this PR to you too to do pairing stuff! |
Sure. I will do it. |
CHANGELOG.md
Outdated
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
### Changed | |||
## [0.1] - 2024-05-29 | |||
### Added | |||
- `CLI` Handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to handler
, is that OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
README.md
Outdated
@@ -35,7 +35,7 @@ | |||
|
|||
## Overview | |||
<p align="justify"> | |||
DMeta is an open source Python package that provides ... TODO | |||
DMeta is an open source Python package that removes metadata of microsoft office files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to ... Microsoft Office ...
, is that OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, go ahead.
README.md
Outdated
|
||
CONFIG_FILE_PATH = os.path.join(os.getcwd(), "CONFIG.json") | ||
DOCX_FILE_PATH = os.path.join(os.getcwd(), "SAMPLE.docx") | ||
update(DOCX_FILE_PATH, DOCX_FILE_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of them should be config, I will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shit, yes you are right, the first one I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @AHReccese
I have a minor comment. Plus that I would suggest to use small case words for file names instead, ex sample.docx
instead of SAMPLE.docx
.
I will apply some changes and do the needed changes in the repository and then you can either apply or ignore these suggestions.
README.md
Outdated
@@ -84,30 +84,68 @@ DMeta is an open source Python package that provides ... TODO | |||
- Run `pip install .` | |||
|
|||
## Usage | |||
### Programmatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using ### In Python
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and apply yourself, then finally ping me, I will review them.
Great Job Sadra, Go ahead and apply them all, then tag me for a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @AHReccese please review. If it is OK, we can merge it.
Ok, great, lemmi review everything and then we will go for it. |
Reference Issues/PRs
#27
test.yml
What does this implement/fix? Explain your changes.
Any other comments?