Adding gstream parsing and a few extra bits of monitoring from XRootD #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR bundling all of the changes made for Edinburgh's monitoring of our proxy cache instances.
I expect there may be some changes/discussion before/if this is merged, however this is the result of the recent work at Edinburgh around this collector for GridPP monitoring.
I've wrapped some handling of the raw data by the collector by a configuration option
process_metrics. In the case of GridPP we don't want to be handling the metrics in the parser as we intend to do this higher up in our ELK+ stack.Hopefully the changes aren't too invasive that this might be useful to someone else.