Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform same newGroupId and newArtifactId validations for Gradle ChangeDependency recipe #3930

Merged

Conversation

shanman190
Copy link
Contributor

@shanman190 shanman190 commented Jan 17, 2024

What's changed?

Added same validation for Gradle ChangeDependency as was done for the Maven equivalent via #3889.

Anything in particular you'd like reviewers to focus on?

I did go ahead and clean up the descriptions a little bit more, so now I think they overall are a bit clearer in terms of intent.

Have you considered any alternatives or workarounds?

N/A

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@shanman190 shanman190 added the enhancement New feature or request label Jan 17, 2024
@shanman190 shanman190 requested a review from timtebeek January 17, 2024 15:52
@shanman190 shanman190 self-assigned this Jan 17, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shanman190 shanman190 merged commit 99f3d6f into main Jan 17, 2024
1 check passed
@shanman190 shanman190 deleted the feature/validate-different-coordinates-gradle-recipes branch January 17, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants