Skip relativePaths containing colon as that fails on Windows #3169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3167
artemis-pom-2.28.0.pom contains a weird relative path: https://repo1.maven.org/maven2/org/apache/activemq/artemis-pom/2.28.0/artemis-pom-2.28.0.pom
This worked okay-ish on Linux/Mac, as passing the relativePath into
Paths.get(relativePath, "pom.xml")
will just result in a nullmaybeLocalPom
. On Windows however, a colon is not valid to pass into Paths.get(..), and it fails with the reported exception.Since we were effectively ignoring the relative path on Mac/Linux before, we might as well skip it entirely for Windows as well.