Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting isEmpty instead of length #211

Closed
wants to merge 1 commit into from

Conversation

jeexan2
Copy link

@jeexan2 jeexan2 commented Nov 3, 2023

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jeexan2 jeexan2 changed the title PR creation Rewriting isEmpty instead of length Nov 3, 2023
@timtebeek timtebeek marked this pull request as draft November 3, 2023 17:44
@timtebeek
Copy link
Contributor

As discussed on openrewrite/rewrite-migrate-java#336 (comment) we should target UseStringIsEmpty.java in https://github.com/openrewrite/rewrite-migrate-java/ instead; that's a different repository to clone, so closing this PR. Thanks for wanting to get started though!

@timtebeek timtebeek closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants