-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use lombok @NoArgsConstructor annotation #645
Conversation
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Outdated
Show resolved
Hide resolved
674399d
to
52339a8
Compare
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @timo-a ! I've added the missing AccessLevel imports and made use of doAfterVisit to simplify the implementation. With that we're ok to merge.
Might make sense to see if any of the improvements applied here and in the logging PR also apply in some the other you have open, as it's taking me a bit to review them all
- feat: use Lombok Log Annotations #644
- feat: use @Data #646
- feat: convert any equals and hashcode to the lombok annotation, ignore implementation #647
- feat: summarize method level getter and setter annotations to one class level annotation #633
- [DRAFT]: feat: normalize effective setter methods #632
- feat: normalize effective getter methods #631
Many thanks for all of these open PRs; really neat to make it easier to use Lombok to the fullest.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist