Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use lombok @NoArgsConstructor annotation #645

Merged
merged 6 commits into from
Jan 5, 2025

Conversation

timo-a
Copy link
Contributor

@timo-a timo-a commented Dec 24, 2024

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review January 1, 2025 14:43
@timo-a timo-a force-pushed the lombok/noargsconstructor branch from 674399d to 52339a8 Compare January 1, 2025 19:15
timtebeek and others added 2 commits January 5, 2025 18:53
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@timtebeek timtebeek added the recipe Recipe requested label Jan 5, 2025
@timtebeek timtebeek marked this pull request as ready for review January 5, 2025 17:54
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @timo-a ! I've added the missing AccessLevel imports and made use of doAfterVisit to simplify the implementation. With that we're ok to merge.

Might make sense to see if any of the improvements applied here and in the logging PR also apply in some the other you have open, as it's taking me a bit to review them all

Many thanks for all of these open PRs; really neat to make it easier to use Lombok to the fullest.

@timtebeek timtebeek merged commit 5b957bb into openrewrite:main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe requested
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants