-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Java 11 recipe -RemovedSecurityManagerMethods #458
Merged
timtebeek
merged 12 commits into
openrewrite:main
from
ranuradh:recipe_removedSecurityManagerMethods
Apr 22, 2024
Merged
Adding Java 11 recipe -RemovedSecurityManagerMethods #458
timtebeek
merged 12 commits into
openrewrite:main
from
ranuradh:recipe_removedSecurityManagerMethods
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Apr 20, 2024
src/main/java/org/openrewrite/java/migrate/RemovedSecurityManagerMethods.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/RemovedSecurityManagerMethods.java
Outdated
Show resolved
Hide resolved
@timtebeek and @cjobinabo could we complete the review and merge this. Since I believe we need this for our next release. |
timtebeek
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, also for the context around the challenges to test this one. Ran a local test and it all works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added recipe for the following:
This recipe replaces methods returning
void
that are deprecated in theSecurityManager
class in Java SE 11.The methods
checkAwtEventQueueAccess()
,checkSystemClipboardAccess()
,checkMemberAccess()
andcheckTopLevelWindow()
are replaced bycheckPermission(new java.security.AllPermission())
.Since it was not possible to test the recipe. I created sample files, created a local plugin using
./gradlew publishToMavenLocal
then ran it in the Java8 Sample App usingmvn rewrite:dryRun
Attaching the rewrite.patch file
rewrite.patch
Anyone you would like to review specifically?
Checklist