feat: Missing "Add explicit Common Annotations dependencies" in "Migrate to Java 11" #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/migrate/javax/AddCommonAnnotationsDependenciesTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
reviewed
Apr 20, 2024
src/main/resources/META-INF/rewrite/add-common-annotations-dependencies.yml
Outdated
Show resolved
Hide resolved
src/main/resources/META-INF/rewrite/add-common-annotations-dependencies.yml
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/javax/AddCommonAnnotationsDependenciesTest.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Thanks a lot for adding this earlier omission; opening it in my IDE I could see the patterns you replicated that weren't immediately clear to me looking at the diff only. Great to see you took the time to implement this in a similar fashion to fit in with earlier approaches.
I've applied a few minor touch ups that I'll try to codify into automated checks going forward.
|
Great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455